-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix macOS CI #31
Fix macOS CI #31
Conversation
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## fix/static-linked-builds #31 +/- ##
=============================================================
- Coverage 84.89% 35.48% -49.42%
=============================================================
Files 27 26 -1
Lines 2575 2100 -475
Branches 574 699 +125
=============================================================
- Hits 2186 745 -1441
- Misses 382 1028 +646
- Partials 7 327 +320
☔ View full report in Codecov by Sentry. |
3890c0b
to
236bdc6
Compare
236bdc6
to
051895a
Compare
051895a
to
b94e90a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, merging!
👋
This MR is intended to appease macOS CI. The sole issue was that there is a dynamic loader race condition with regards to the crunch that's linked to the runner by Meson (loaded with rpath) and the one that's linked to the test libraries (loaded with full path).